Vignette - controllable shape and position

nick · April 28, 2020, 3:13pm

Hey folks! New Shotcut user, so psyched this is OSS! Two requests for the vignette plugin:

Shape - Adobe Lightroom has this really useful concept of “roundness” that allows you to control the shape of the vignette, ranging from basically the rectangular shape of the frame, through an oval shape, to the circle. This might not be something movit currently supports; not sure how to go about adding, perhaps that would be an email to Sesse.
Center position - I want to move the center of the vignette effect away from the center of the frame. I think movit already supports this, just a question of adding a control to the Shotcut integration.

I’m happy to try and contribute these, if these are ok changes.

shotcut · April 28, 2020, 10:05pm

Please be aware that we no longer use Sesse’s Movie repository since it has required newer versions of OpenGL that do not integrate with our usage of Qt Quick for video display with overlay UI. Also, GPU Effects has been hidden for a long time now due to instability. Here is the fork I am using

The future of Movit within Shotcut is very uncertain especially as OpenGL deprecates. Any additional parameters added in Movit needs to be added in the MLT plugin as well.

nick · April 30, 2020, 2:44am

Ok cool, down to build it in that repo instead. That said, if GPU effects are not in use, is the MLT plugin the real place to work on the effect I was using? Looks like probably this file?

github.com

mltframework/mlt/blob/master/src/modules/oldfilm/filter_vignette.c

/*
 * filter_vignette.c -- vignette filter
 * Copyright (c) 2007 Marco Gittler <g.marco@freenet.de>
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
 */

#include <framework/mlt_filter.h>

This file has been truncated. show original

shotcut · April 30, 2020, 4:31am

That is the non-GPU version of the Vignette filter in Shotcut.