V19.12 BETA now available

I tested it on a transparent clip.

Yes, but I forgot to mention this filter only supports simple keyframes for Position and Size only due to a technology mismatch between the frei0r backend and the Shotuct UI with respect to a rectangle data type (frei0r lacks it).

I am still thinking of simple, clean, and obvious way to indicate which parameters participate in simple keyframes. Bold labels? An icon like that looks like a trapezoid or {} placed where: before label, after label, in a column after the reset/undo button?

Ripple trim and drop is broken.
With Shotcut 19.10, when ripple trim and drop is active a clip moved to the right pushes clips to the right of it along the timeline. The same clip moved left pulls the clips to the right along the timeline.
19.12 Beta only moves the clips to the right. When a clip is pulled left the clips on the right do not move.

I am still unable to reproduce trying multiple ways. It probably depends on something specific:

  • tested on Windows with Explorer and Linux with GNOME Files, which are you using today?
  • every playlist view mode
  • with and without album art
  • video mode set to Automatic or 720p50
  • new, empty session
  • project loaded
  • load a project and File New/Close (they do the same thing :slight_smile: )
  • 1 file or multiple dragged

This happens with Windows 10 1909. Haven’t tried Linux.
As of this morning it is still happening

It might have something to do with my system and not Shotcut.:weary:

Tested the mp3 issue with Shotcut 19.10.20 and 19.12.09 Linux Fedora 30.
There is no problem with dragging and dropping an mp3 file on the playlist panel.

It seems the issue is with my Windows setup.

I reproduced this and fixed it.
I also found that combination of ripple, multi-select on same track, and dragging to the same track is crashy and nonsensical. I fixed that too by using the leftmost selected clip.

How about just underlining the name of that parameter? And then if you hover the mouse on it have a text box appear that says “Simple Keyframes Available” or “Only Simple Keyframes Available”.

Speaking of text boxes, the ones for the Simple Keyframe buttons like for setting the start and end for trimming should be updated so that they say what the shortcut keys are for them.

So here are the issues I found so far with this beta:

1 - Pick a filter that has Keyframes with curves. Use the trim filter to set the start of the filter later in the clip. Activate Advanced Keyframes. Set the playhead later in the clip and press the button to set a new keyframe where the playhead is. The keyframe will not be set where the playhead is. Instead it will be set further down the clip. Demo.

2 - Selecting the Properties tab by right clicking on a clip does not open up the Properties tab. It works for trackheads and the Master track but not for clips in the timeline.

3 - I don’t know if this one is a feature or a bug. When a clip is dragged to a second clip where there is a gap in between them it now creates a transition. However, if the first clip selected is on the left side of the second clip and it’s dragged to the right side of the second clip to create a transition then a transition won’t be created. Instead, it will overwrite the second clip. Demo.

4 - If the above is a feature then there is a bug related to it. If a clip is overwritten by a second clip below the first clip, undoing the action will mess up the timeline. In some cases, undoing and redoing the action can even cause Shotcut to crash. Demo.

5 - Changing the speed of a clip in Properties will change from where the clip is taken from the timeline. This happens whether you are slowing down or speeding up a clip. In this demo, I cut a section from the video clip that comes in a little over 1 minute in. I go to slow down the clip in Properties and after I do that the clip now plays from the beginning of the whole video file. I show in the demo the first and last frame of the clip before I change the speed to show that the clip is taken from that one specific section. After I change the speed of the clip, I go back to show the first and last frame of that same clip to show that it is of a totally different part of the video which is from the very start.

6 - There is nothing stopping multiple clips from being dragged all the way passed defined sections of the timeline. If you select multiple clips to move, and select as the main clip to indicate the movement the furthest clip away from the defined point, then the clips that are to follow can be moved to the left past the start of the timeline or above beyond the set amount of video tracks in the timeline. If multiple clips are moved beyond the left of the timeline that it will cause the clips to be altered in the timeline. Here’s a demo of that. If the multiple clips are moved to go beyond the amount of video tracks set, it will cause Shotcut to crash. In this demo, after I try to move multiple clips up beyond V2, you will notice that Shotcut freezes. After it froze, Shotcut crashed right after that.

7 - There are times when moving multiple clips ends up overwriting clips that are in the same line of selected clips instead of just moving all the clips accordingly. Here is a demo of one instance where I had two video tracks of clips and I attempted to move one line of clips on V1 which had 6 clips and after trying to move all of them to the right, the 6 clips were overwritten to 5 with some of those clips heavily shortened.

8 - Drag the 1st clip closer to a 2nd clip but drop the 1st clip so that there is still a gap in between. Then take the 1st clip again and drag it to the 2nd clip so that it creates a transition. When you hit Undo, the clip or clips that follow the 1st clip are thrown down the timeline. Demo.

9 - Right now after dragging multiple clips once all the clips are deselected. Can this be changed to keep the clips selected after dragging and dropping multiple clips around the timeline? If I move multiple clips around and drop them but then change my mind and want to move them elsewhere I would have to reselect all of them.

10 - Can shortcut keys be added for these seek buttons in Advanced Keyframes:

How about Alt+; and Alt+’ ?

Underline is ugly IMO. In the next beta 19.12.09 I am preparing now, I put “{ }” before the labels in the new Gradient filter so people can see it and give an opinion.

1 not new
2 broke in v19.09 and is minor, but I will probably fix it
3 is a new change and working as expected
5 I need to revert a bug fix that is causing more trouble than worth.
7 is working as intended even if not what you expect. Moving multiple clips without ripple on does a lift and overwrite operation on each one-by-one. It is hard to predict what you will get. With ripple on, it pushes using the left most in the selection using the new beta 19.12.09
9 & 10 Not now

As you can see moving multiple clips is tricky not just for the programmer but also for users to predict what is going to happen in many cases. There are so many corner cases. But it does not stop people from begging even if it is going to destabilize.

UPDATE 1:
1, 2 & 5 were easy fixes for the next version after 19.12.09

UPDATE 2:
6 is fixed. 4 & 8 are undo-related as mentioned in first post

UPDATE 3:
I think 7 is kind of a big deal and is going to throw a lot people and use cases. I think I need to change the logic to first lift every selected and then overwrite with everything selected. That is a very big change with a lot of work. So, I am going to disable multiple move for this release to rework this area more.

I uploaded a new version 19.12.09 to the beta page and removed the older one.
It fixes:

  • loading an older project that includes a transition and using a relative path anywhere
  • moving timeline clip left in ripple mode
  • removed showing a keyboard shortcut to reset track height
  • added simple animation indications { } to gradient filter
1 Like

I downloaded the new beta and I think that “{ }” is awkward by being placed before each line of Position and Size. People are not going to naturally associate “{ }” with Simple Keyframes. Since you don’t like underlining the names of the parameters but want “{ }” to be associated with Simple Keyframes then I think a better placement of “{ }” is have it take the place of the Advanced Keyframe button that is on the Size and Position and Text filters (on the right side of the value boxes in the middle of Position and Size). Then have a dialog box appear after “{ }” is clicked on saying something like "Only Simple Keyframes Available”.

Sorry about that but you wrote that the undo bugs you were aware of were associated with multiple-selected clips. 4 & 8 were not triggered by multiple-selected clips. I thought they were triggered with the change of now being able to create a transition clip after dragging past a gap.

That sounds good. Do you want any more bugs to be reported on here in this thread then? Are you going to be fixing other bugs before this release?

Ok Thanks for the feedback. I’ll nix that idea. The idea is not that it means only advanced keyframes but merely that this parameter is involved in simple. The idea is to add something to every filter with this indication. Many parameters in other filters support both kinds of keyframes.

At this point I only have time for the undo related bugs and anything that is severely broken and going to give current users already successfully using it major grief.

Just a thought, why not put “Position” and “Size” both inside square brackets?

[Position]

[Size]

Maybe that would visually look better than curly brackets to the left ? (yes I’m with @drm, they do look a little odd imo :wink:)

Or … bullets to the left of the position/size text?

The square brackets in the Keyframes toolbar and the square bracket keyboard shortcuts are used for filter trimming. The curly braces are used for simple keyframes. Hence, that ties them together. I looked at putting the label inside curly braces, but I did not like the look of it. I also tried making the label bold, but that is rather subtle. Bullet might be an option.

FYI, a performance regression that was addressed:

Thanks Dan. PS the gradient filter is very cool :smiley::+1:

It still needs more than 80 percent rendering time compared to the version 19.09.14 without hardware acceleration.

I made an image to show what I meant by my last suggestion for a visual indication of Simple Keyframes for the size and position parameters in the Gradient filter. I used the Size and Position filter just to make the point.

So here it is as it is now with the Advanced Keyframe icon:

And here’s what I suggested:

I think it would be good to put that symbol in the same place as where the Advanced Keyframe would normally be because that’s where experienced Shotcut users would expect to find the Advanced Keyframe button. So seeing “{ }” in its place would let the user know that they keyframe function is different. The addition of a text box that would appear when the mouse hovers over it letting the user know only simple keyframes are available would then help people from then on associate the symbol “{ }” with the Simple Keyframe function.

Maybe an hourglass icon could be used to indicate simple keyframes.:grimacing:

HGlass

Another suggestion…
A more “complicated” stopwatch icon for advanced keyframes:
56%20PM

And a simpler one for, well, simple keyframes:
03%20PM

1 Like

I like the idea of an hourglass icon for Simple Keyframes. :slightly_smiling_face: It symbolizes very well the idea of a simple tool for time while also being totally distinct visually from a stopwatch.

The difference between the two stop watches is subtle, and an indication is not a button. People will be clicking it to add a keyframe and get frustrated and complain. And I don’t want to make it into a button that opens a dialog window. The curly braces in a column after the reset buttons might be ok. Of course, none of this is for the next release and is off topic, but I do appreciate the ideas. Hourglass… well we already have a number of time related icons. See the main tool bar: recent, timeline, keyframes, history. :-S