Timer filter's useful buttons are useless if filter in point is set

TRA · June 25, 2021, 8:09pm

> buttons for Start Delay and Duration in Timer filter become useless if filter in point is changed from the default position.

I made the following change to Timer filter’s ui.qml and that seems to have fixed the problem.

Line	Before	After
199	`producer.position / profile.fps`	`(producer.position - (filter.in - producer.in)) / profile.fps`
228	`producer.position / profile.fps`	`(producer.position - (filter.in - producer.in)) / profile.fps`

github.com

mltframework/shotcut/blob/master/src/qml/filters/timer/ui.qml#L199

    
      
                      startSpinner.timeStr = _defaultStart
                  }
                  Shotcut.HoverTip { text: qsTr('The timer will be frozen from the beginning of the filter until the Start Delay time has elapsed.') }
              }
              Shotcut.Button {
                  icon.name: 'insert'
                  icon.source: 'qrc:///icons/oxygen/32x32/actions/insert.png'
                  Shotcut.HoverTip { text: qsTr('Set start to begin at the current position') }
                  implicitWidth: 20
                  implicitHeight: 20
                  onClicked: startSpinner.setValueSeconds(producer.position / profile.fps)
              }
          }
          
          
Label {
              text: qsTr('Duration')
              Layout.alignment: Qt.AlignRight
          }
          RowLayout {
              spacing: 0
              ClockSpinner {

github.com

mltframework/shotcut/blob/master/src/qml/filters/timer/ui.qml#L228

    
      
                  Shotcut.HoverTip { text: qsTr('The timer will be frozen after the Duration has elapsed.') }
              }
              Shotcut.Button {
                  icon.name: 'insert'
                  icon.source: 'qrc:///icons/oxygen/32x32/actions/insert.png'
                  Shotcut.HoverTip { text: qsTr('Set duration to end at the current position') }
                  implicitWidth: 20
                  implicitHeight: 20
                  onClicked: {
                      var startTime = startSpinner.getValueSeconds()
                      var endTime = producer.position / profile.fps
                      if (endTime > startTime) {
                          durationSpinner.setValueSeconds(endTime - startTime)
                      }
                  }
              }
          }
          
          
Label {
              text: qsTr('Offset')
              Layout.alignment: Qt.AlignRight

brian · July 5, 2021, 2:13pm

Thanks for your report. This is fixed for the 20.07 release.