Problem about Size & Position keyframe in the latest update

Ghonich · April 24, 2022, 9:28am

What is your operating system?
Windows 10 64bit

What is your Shotcut version (see Help > About Shotcut)? Is it 32-bit?
22.04.22

Can you repeat the problem? If so, what are the steps?
When I apply “Size, Position & Rotate” video filter and add some keyframes of the size & position, it seem like that the first keyframe was locked in 00.00.00.01 frame, even if I click the “Use keyframe for this parameter” button in other frames. And then when I try to add and edit other keyframes, I was editing the first keyframe instead of the others.

This problem didn’t happened in the keyframe of rotation, only size & position.

Hudson555x · April 24, 2022, 9:57am

I can confirm. All keyframes are bound for the first keyframe of the clip.

Other bugs:

Can’t scroll wheel up/down to set keyframe in position numbers.
Playhead can be elsewhere than the first frame of clip, activated keyframes always inserts the value at the first frame of the clip.
Deleting the keyframe in the first frame, will reinsert itself after deleting it, and attempting to place one somewhere else.
VUI is out of sync.

brian · April 24, 2022, 9:44pm

Thanks for the report and testing on this. This is a pretty major regression and we might need to issue a re-release.

I think I have found the problem, and it could affect any filter that uses the rectangle VUI and keyframes. Would anyone be willing to test all the filters that use the rectangle VUI and report back which ones are broken?

Hudson555x · April 24, 2022, 10:23pm

Crop: Rectangle
GPS Text
Spot Remover
Text: Rich
Text: Simple
Timer
Open Other - Text

brian · April 24, 2022, 10:29pm

Thanks for the additional testing. This is fixed for the next release.

TRA · April 25, 2022, 2:00am

It looks like a file is missing from the commit:

/src/qml/filters/gradient/ui.qml

Line	Before	After
102	`filter.set(rectProperty, rect, 1.0, position)`	`filter.set(rectProperty, rect, position)`

This solves the problem of not being able to change the rect of the start simple keyframe through the filters dock.

github.com

mltframework/shotcut/blob/5ef0b5e1045e7f09aa829f4be401307423135ec7/src/qml/filters/gradient/ui.qml#L102

      
        
                filter.resetProperty(rectProperty)
                filter.resetProperty(startXProperty)
                filter.resetProperty(startYProperty)
                filter.resetProperty(endXProperty)
                filter.resetProperty(endYProperty)
            }
            
            
function updateFilterRect(rect, position) {
                if (position === null)
                    position = -1
                filter.set(rectProperty, rect, 1.0, position)
                if (filter.get(patternProperty) === 'gradient_linear') {
                    filter.set(startXProperty, rect.x / profile.width, position)
                    filter.set(startYProperty, rect.y / profile.height, position)
                    filter.set(endXProperty, (rect.x + rect.width) / profile.width, position)
                    filter.set(endYProperty, (rect.y + rect.height) / profile.height, position)
                } else {
                    filter.set(startXProperty, (rect.x + rect.width / 2) / profile.width, position)
                    filter.set(startYProperty, (rect.y + rect.height / 2) / profile.height, position)
                    filter.set(endXProperty, (rect.x + rect.width) / profile.width, position)
                    filter.set(endYProperty, (rect.y + rect.height) / profile.height, position)

brian · April 25, 2022, 3:24am

Great catch! Thanks. I have fixed that one. Let me know if you see any others - but I’m pretty sure we got them all.