Position timecode not fully show up in 19.02.28

chenshaoju · March 4, 2019, 2:27am

Sorry for my English.

Version: 19.02.28

In Windows 7 x64 Simplified Chinese OS, The lift timer does not fully show up, Look like this:

I guess this is a font issue ( size? ), How can I change the font in Shotcut for a try?

Thanks.

shotcut · March 4, 2019, 8:55pm

Yes, this appears to be a font size issue with the system font for Simplified Chinese or if you changed it? We use a font metrics API to compute a fixed width, but it is not enough on your system.

github.com

mltframework/shotcut/blob/master/src/widgets/timespinbox.cpp#L31


#include <QRegExpValidator>
#include <QKeyEvent>
#include <QFontDatabase>
#include <QGuiApplication>


TimeSpinBox::TimeSpinBox(QWidget *parent)
: QSpinBox(parent)
{
setLineEdit(new TimeSpinBoxLineEdit);
setRange(0, INT_MAX);
setFixedWidth(this->fontMetrics().width("HHH:MM:SS.MMM"));
setAlignment(Qt::AlignRight);
m_validator = new QRegExpValidator(QRegExp("^\\s*(\\d*:){0,2}(\\d*[.;:])?\\d*\\s*$"), this);
setValue(0);
#ifdef Q_OS_MAC
QFont font = QFontDatabase::systemFont(QFontDatabase::FixedFont);
font.setPointSize(QGuiApplication::font().pointSize());
setFont(font);
#endif
}

Obviously, I need to increase the width for when the FPS > 99, but it seems something else is needed for your font. Looking at API docs, I see I can use boundingRect().width() instead of simply width(). I will make some changes here for the next version, and we will see what happens. You can test a 19.03 beta when it becomes available.

chenshaoju · March 5, 2019, 8:39am

Thanks for the reply.

Yes, I changed the font by using MacType ( https://www.mactype.net/ ).

But I have another Windows 10 Laptop, Not install MacType.

It’s looks like same:

I will test 19.03 when it out, Thank you!

chenshaoju · May 3, 2019, 3:17am

This issue has been fixed in 19.04.30, Thank you!

unnamed