Part of a clip's tooltip is inaccurate after the out point trim handle is dragged half way

TRA · August 5, 2021, 8:09pm

This appears to happen regardless of the type of the source file. It could be an image, video, or audio.

Tested with v21.06.29.
Tested on Windows.

TRA · November 11, 2021, 1:25pm

The same bug is happening in the Keyframes dock.

I also found some other inaccuracies in plus or minus portion of the help bubble on the Keyframs dock.

And also on the timeline dock if the in trim point is somewhat stuck due to snapping.

I have made a pull request here to address all of these inaccuracies:

github.com/mltframework/shotcut

Improve accuracy of delta portion of bubblehelp while trimming on Timeline and Keyframes

mltframework:master ← traprog:improve_bubblehelp

opened 01:24PM - 11 Nov 21 UTC

traprog

+10 -4

timeline/Track.qml - `else` clause for `if (delta != 0)` means the trim handle …is being stuck due to snapping enabled. Accumulated delta `clip.originalX` needs to be adjusted in the same manner as when `timeline.trimClipIn` or `timeline.trimClipOut` returns `false`. keyframes/keyframes.qml - `else` clauses in `onTrimmingIn` and `onTrimmingOut` are equivalent to when `timeline.trimClipIn` or `timeline.trimClipOut` returns `false` in the Timeline. Clip.qml - Somehow `- originalX - delta` is double-counting or something. `delta` accumulation stops half way trimming. I feel like this `if` statement check of a clip becoming very thin is taken care of by `clip.originalX -= originalDelta` or `clip.originalX -= delta` in the files above.