Old bug reappears after a fix (trim clip can truncate frames)

TRA · June 19, 2022, 6:59am

This bug reappeared

after this bug was fixed and is still present in v22.04.25.

I’ve created a pull request that addresses both bugs here:

github.com/mltframework/shotcut

Fix trim clip can truncate neighboring clip

mltframework:master ← traprog:trim_clip_transition

opened 06:56AM - 19 Jun 22 UTC

traprog

+14 -4

If `delta` is negative in `trimClipIn()`, a user is deleting an existing transit…ion. If `delta` is positive, a user has added a transition, changes course, and deletes the added transition. Same thing with `trimClipOut()` In the first case, `m_trimDelta` need to be adjusted by `n` frames because that's how many frames were left before an existing transition is erased. In the second case, `m_trimDelta` requires no adjustment because a user has been manipulating `m_transitionDelta`. As soon as the added transition is erased, `m_transitionDelta` should become 0.

I’ve successfully compiled both Shotcut and Mlt through Windows SDK so this code change went through a bit of testing, and it is working quite well.

shotcut · June 19, 2022, 7:38pm

Thanks, I reproduced, tested this fix, and merged it for the next release.