Grid lines disappear under zoom

TRA · June 25, 2021, 8:05pm

2x2 Grid lines disappear if the player zoom level is 100% or more.

3x3, 4x4, and 16x16 Grid lines don’t disappear completely, but rightmost and bottom lines disappear as the player dimensions change.

Just adding an extra loop in the for statement here and other places:

github.com

mltframework/shotcut/blob/master/src/qml/modules/Shotcut/Controls/VuiBase.qml#L41

    
      
          if (video.grid === 8090) {
              // 80/90% Safe Areas
              ctx.rect( 0.1 * rectW + rectX + 2,  0.1 * rectH + rectY + 2, 0.8 * rectW - 1, 0.8 * rectH - 1)
              ctx.rect(0.05 * rectW + rectX + 2, 0.05 * rectH + rectY + 2, 0.9 * rectW - 1, 0.9 * rectH - 1)
          } else if (video.grid == 95) {
              // EBU R95 Safe Areas
              ctx.rect( 0.05 * rectW + rectX + 2,  0.05 * rectH + rectY + 2,  0.9 * rectW - 1,  0.9 * rectH - 1)
              ctx.rect(0.035 * rectW + rectX + 2, 0.035 * rectH + rectY + 2, 0.93 * rectW - 1, 0.93 * rectH - 1)
          } else {
              // vertical grid lines
              for(var x = 0; x * gridSizeX < parent.width; x++)
              {
                  context.moveTo(gridOffsetX + x * gridSizeX + 1, 0)
                  context.lineTo(gridOffsetX + x * gridSizeX + 1, parent.height)
              }
              // horizontal grid lines
              for(var y = 0; y * gridSizeY < parent.height; y++)
              {
                  context.moveTo(0, gridOffsetY + y * gridSizeY + 1)
                  context.lineTo(parent.width, gridOffsetY + y * gridSizeY + 1)
              }

by making the following change has fixed the problem.

Line	Before	After
41	`for(var x = 0; x * gridSizeX < parent.width; x++)`	`for(var x = 0; x * gridSizeX < parent.width + gridSizeX; x++)`
47	`for(var y = 0; y * gridSizeY < parent.height; y++)`	`for(var y = 0; y * gridSizeY < parent.height + gridSizeY; y++)`
72	`for(var x = 0; x * gridSizeX < parent.width; x++)`	`for(var x = 0; x * gridSizeX < parent.width + gridSizeX; x++)`
78	`for(var y = 0; y * gridSizeY < parent.height; y++)`	`for(var y = 0; y * gridSizeY < parent.height + gridSizeY; y++)`

MusicalBox · June 26, 2021, 12:02am

Works fine on Windows 10

brian · July 5, 2021, 1:57pm

Thanks for your report. This is fixed for the 20.07 release.