Them being duplicated buttons on both toolbars that share the same function is exactly my suggestion. 
Turning snapping on and off as needed is so common that it needs to be easily accessible.
Thanks for the suggestion. I think I am leaning that way. The side effect will be that if the user has both the keyframes and timeline panels open, if they click the “snap” button on one toolbar, they will see the button on the other toolbar also depress. Probably not a big deal.
I have fixed this.
I have not implemented the enable/disable for snapping.
@brian, so the snapping here is helping to end and start clips with the frames that I want but there is another issue with the testing that I am doing that I’m seeing that makes the filter fickle. That’s when the clip is either extended from the start. This changes all of the frames that each keyframe represents. I remember this behavior was changed to be this way but I think this needs to be overhauled because I don’t see how this is useful.
If I create a little Time Remap section and want to add a transition with another clip at the start of the Time Remap clip, this ruins all of the keyframes I set including what was supposed to be the last keyframe of the clip that I set which would ruin the sequence because it won’t match with whatever clip I want to follow the Time Remap clip. I think when the clip is extended at the front, including to make a transitions, the keyframes should stay on the frames they were set to be on.
Since the Time Remap filter covers the entire source clip I believe the way to remedy this is to automatically add two keyframes that cannot be deleted: One at the start and one at the end of the source clip which may go unseen by the user if they are just working on a split section. That would allow a clip to be extended from the start and not mess up the frames that the set keyframes are meant for in the section where Time Remap is applied.
We had talked about ripple move for keyframes. I think that could be a way to fix it. After the beginning of the clip is extended, you could ripple-drag the first keyframe back to the frame that you want to associate with it.
Yes we did but this is a different issue really.
In the current design, if you extend the clip from start then the added part at the start freezes until it gets to the first keyframe that was set when Time Remap was first applied. This is not useful especially when adding transitions. If someone wants to extend the clip and have it freeze at the start then they could just do that manually. And this also shifts all of the frames the keyframes are representing. No other filter behaves this way.
By automatically setting two keyframes that can’t be deleted at the first frame and the last frame of the source clip, it will anchor everything. Those two keyframes cannot be removed and they can’t be moved left to right. They can be moved up and down so one could reverse the whole source clip but they don’t move left and right or can ever be deleted because they hold the whole source clip together.
By putting keyframes that can’t be deleted at start of the source clip, it will allow the clip to play normally like the clip always would after it is extended rather than freezing. Also with both keyframes at start and end of source clip it will also lock whatever frames the keyframes are set to so that they won’t be altered when moving extending clips from the start.
Doing this would really help people get a grasp on how this filter works because it would make the behavior much more consistent with the keyframes of all the other filters.
So along with the issue I laid out above with the structure of Time Remap, there is something else that is also standard along with keyframes snapping to the playhead that isn’t in Shotcut yet. That is multi-selecting keyframes for different actions like for dragging, deleting, changing the type of keyframe, etc… This is more important to have before even getting to any kind of rippling keyframes.
The only thing is I am not sure how it would totally work since doing multi-select with Shift and Ctrl is standard but with keyframes Ctrl is used to lock keyframe movements to up and down. Still, this is a standard function for keyframes and is very badly needed.
1 Like
I would love to have the ability at least to be able to copy and paste keyframe values.
Say you have an object you’d like to move around the screen using SPR keyframes then return it back to its original position it would be great to have icons on the keyframe panel the same as for copy/paste filters. I do this action quite often but at the moment I find myself having to write down all 4 SPR values then re-input them. A real pain. All other videos I know have this copy/paste keyframe feature.
1 Like
Just for information, here’s how keyframe copy/paste icons look in Magix Movie Edit Pro (see top bar in the photo). It would be awesome in SC! Plus, also, ripple keyframes would be wonderful 
:
This is done now. Thanks for the discussion.
1 Like