A marker gets deleted when I move a clip leftward

TRA · December 21, 2021, 10:28pm

I wish I had found this before the 21.12.21 release, but here is a bug I encountered on a more complex project:
a marker gets deleted when I move a clip leftward

if the marker’s start point and the clip’s in point is exactly the same
if the ripple marker with edit is turned on.

Final800×450 96.9 KB

Workaround is advance the start point of the marker by one frame.

It looks like line 554 here:

github.com

mltframework/shotcut/blob/master/src/commands/timelinecommands.cpp#L554

    
      
                  m_markersModel.doReplace(m_markers);
              }
          }
          
          
void MoveClipCommand::redoMarkers()
          {
              if (m_rippleMarkers && m_markerOldStart >= 0) {
                  m_markers = m_markersModel.getMarkers();
                  QList<Markers::Marker> newMarkers = m_markers;
                  bool markersModified = false;
                  int startDelta = m_markerNewStart - m_markerOldStart;
                  for (int i = 0; i < newMarkers.size(); i++) {
                      Markers::Marker& marker = newMarkers[i];
                      if (marker.start < m_markerOldStart &&
                          marker.start > m_markerNewStart) {
                          // This marker is in the overwritten segment. Remove it
                          newMarkers.removeAt(i);
                          i--;
                          markersModified = true;
                      } else if (marker.start >= m_markerOldStart) {
                          // This marker is after the start of the moved segment. Shift it with the move

doesn’t need the = sign.

Line	Before	After
554	`marker.start <= m_markerOldStart`	`marker.start < m_markerOldStart`

brian · December 24, 2021, 3:44am

Thanks for your report. This is fixed for the next release.