Problem with calculated timestamps

shotcut · August 18, 2023, 6:51pm

Here is the code. If you attempt to state how it is wrong, bear in mind that it was written to make unit tests pass the enforce that a conversion from frame count to timecode and back to frame count (see other code in the same file) gives the same count for every 32-bit signed int. Any suggestion on your part must be in the form of a pull request that passes the unit tests included in the repo:

github.com

mltframework/mlt/blob/master/src/framework/mlt_property.c#L936


      
              } else if (that->animation && that->serialiser) {
                  self->types = mlt_prop_string;
                  self->prop_string = that->serialiser(that->animation, default_time_format());
              } else if (that->types & mlt_prop_data && that->serialiser) {
                  self->types = mlt_prop_string;
                  self->prop_string = that->serialiser(that->data, that->length);
              }
              pthread_mutex_unlock(&self->mutex);
          }
          
          /** Convert frame count to a SMPTE timecode string.
           *
           * \private \memberof mlt_property_s
           * \param frames a frame count
           * \param fps frames per second
           * \param[out] s the string to write into - must have enough space to hold largest time string
           */
          
          static void time_smpte_from_frames(int frames, double fps, char *s, int drop)
          {
              int hours, mins, secs;