In the release notes list I think you should also add this new little feature otherwise I don’t think anyone would find out about it:
- GPS filters: automatically load a companion gps file (with the same name)
In the release notes list I think you should also add this new little feature otherwise I don’t think anyone would find out about it:
Hi everyone,
The commit b67ea656 (“Fix B-frames in custom export preset (#1935)”) introduced a regression for HEVC NVENC encoding on my Pascal GPUs (GTX 1050/1060 etc. with SM 6.1).
Root cause: The change from onVideoCodecComboChanged(index, false) to onVideoCodecComboChanged(index, true, false) sets resetBframes=false, which keeps B-frames at default value (3) for HEVC NVENC. However, Pascal GPUs only support 0 B-frames for HEVC NVENC, causing crashes at ~81% export.
Mistral.IA propose this fix : Keep ignorePreset=false to load presets correctly, but always force B-frames=0 for HEVC NVENC regardless of preset value. This:
•
Fixes #1935 (presets load correctly)
•
Fixes Pascal GPU crashes (B-frames=0 for HEVC NVENC)
•
No regression for other codecs
Suggested patch for encodedock.cpp :
(-) onVideoCodecComboChanged(ui->videoCodecCombo->currentIndex(), true, false);
(+) onVideoCodecComboChanged(ui->videoCodecCombo->currentIndex(), false, false);
And eventually add explicit B-frames=0 for HEVC NVENC in the function body :
if (resetBframes && vcodec.startsWith(“hevc_”))
if (vcodec.contains(“nvenc”))
ui->bFramesSpinner->setValue(0);
else if (resetBframes) {
ui->dualPassCheckbox->setChecked(false);
ui->dualPassCheckbox->setEnabled(false);
}
I’m actually trying to compile with these…
I think it’s easier to just change the b-frames value in the export panel (Advanced mode, then Codec tab) to 0 and save it as a preset, there’s no need to recompile the entire program just for this.
For us, you’re right, but for new users, we might as well avoid them submitting a bug if they encounter the same problem ![]()
That is a good report, but the problem is that it is tricky. Another user will report will report a bug that a custom preset with B frames > 0 does not load that value from a custom preset (#1935). The suggestion is incorrect; changing that does not affect this. I think Mistral misunderstood the meaning of “ignorePreset” in this context. That is not about loading a Shotcut export preset; it is about removing a “preset” line within a preset. Confusing, I know, many codecs have their own “preset” systems. For example, x264 has slow or fast.
The problem with “always force B-frames=0 for HEVC NVENC regardless of preset value” is that it is a lowest common denominator solution. There are more NVIDIA users on later generations than yours, which is the oldest one that is still supported in Shotcut.
You’re surely right Dan, it was just that I didn’t have the problem before the #1935 which seems to have a direct link, but in reality, the correlation is not logical.
In any case, my tests with this correction from Mistral are not satisfactory.
Alternatively, could we consider adding legacy encoder preset for HEVC and h.264 with bf = 0 ?
I fixed it so that it defaults to 0 B frames but still loads a value > 0 from a custom preset, which was always the intention.